David Anderson
485ade2610
Fix a number of inconsistencies in plugin state.
...
1. Fixed OnPluginUnloaded not pairing if the plugin failed.
2. Unify error message handling in the second pass.
3. Do not add libraries if a plugin failed during OnPluginStart.
2015-10-31 17:25:59 -07:00
David Anderson
9e4fff3362
Add a state variable to CPlugin to indicate queue/list membership.
2015-10-31 17:25:59 -07:00
David Anderson
7cc911ae58
Separate plugin unloading into an eviction step, which disconnects the plugin from Core.
...
Note: this also ensures that library action callbacks are balanced (i.e., we do not notify
libraries are being dropped if they were never notified as being added).
2015-10-31 17:25:59 -07:00
David Anderson
82ff7d5af7
Rename CPlugin::SetErrorState to EvictWithError.
2015-10-31 17:25:59 -07:00
David Anderson
c4c6efb140
Remove a crazy unused function from CPluginManager.
2015-10-31 17:25:59 -07:00
David Anderson
f078ea1f8a
Remove the Illiad-length mostly-wrong comment at the top of PluginSys.h
2015-10-31 17:25:59 -07:00
David Anderson
ab1b915a3c
Fix re-entrancy issues in CPluginManager by using ReentrantList.
2015-10-31 17:24:22 -07:00
David Anderson
709149fbed
Remove the CPluginIterator cache.
2015-10-31 17:23:24 -07:00
David Anderson
e57a076dc8
Remove CPluginManager's friend access to CPlugin.
2015-10-31 17:19:10 -07:00
David Anderson
c21b3a36fc
Remove CPluginManager direct use of CPlugin::NativeOwner::m_fakes.
2015-10-31 17:19:10 -07:00
David Anderson
f765c8d436
Remove CPluginManager direct use of CPlugin::m_LibraryMissing.
2015-10-31 17:19:10 -07:00
David Anderson
ae44a6540a
Remove CPluginManager direct use of CPlugin::m_FakeNativesMissing.
2015-10-31 17:19:10 -07:00
David Anderson
f27dbaf716
Remove CPluginManager direct use of CPlugin::m_RequiredLibs.
2015-10-31 17:19:10 -07:00
David Anderson
717ad38d06
Remove CPluginManager direct use of CPlugin::m_errormsg.
2015-10-31 17:19:10 -07:00
David Anderson
60f06d1414
Remove CPluginManager direct use of CPlugin::m_FileVersion.
2015-10-31 17:19:10 -07:00
David Anderson
a579136a3d
Remove CPluginManager direct use of CPlugin::m_DateTime.
2015-10-31 17:19:10 -07:00
David Anderson
2f3d523ac0
Remove CPluginManager use of CPlugin::m_pRuntime.
2015-10-31 17:19:10 -07:00
David Anderson
df5c53fa4a
Remove CPluginManager direct use of CPlugin::m_filename.
2015-10-31 17:19:10 -07:00
David Anderson
46c069dbbe
Remove CPluginManager direct use of CPlugin::m_Libraries.
2015-10-31 17:19:09 -07:00
David Anderson
bda9defc0f
Remove CPlugin's friend access to CPluginManager.
2015-10-31 17:19:09 -07:00
David Anderson
6c5ab80418
Refactor and cleanup the AMBuildScript a bit.
2015-10-08 14:55:53 -07:00
David Anderson
88a47ff681
Switch to re-entrant lists in ForwardSys and CForward.
2015-09-21 01:07:34 -07:00
David Anderson
c1396de2fc
Replace SourceHook::List with ke::LinkedList in ForwardSys.
2015-09-21 01:07:25 -07:00
David Anderson
0810c4b217
Fix style issues in ForwardSys, removing extra blocks and tightening variable scope.
...
This also fixes a bug where IsFunctionRegistered() did not check the paused plugins list.
2015-09-21 01:07:18 -07:00
David Anderson
632c7d05dd
Remove the forward cache and simplify CForward construction.
2015-09-21 01:07:01 -07:00
David Anderson
dcc192ee0d
Use new header style.
2015-09-21 01:06:43 -07:00
David Anderson
9b1678bd18
Remove error outparams from first-pass internal plugin loading commands.
2015-09-21 00:51:20 -07:00
David Anderson
5f19fc036d
Refactor AskPluginLoad() to contain its own error state.
2015-09-21 00:51:16 -07:00
David Anderson
5eec2e7d6d
Remove error message outparam to LoadExtensions.
2015-09-21 00:51:11 -07:00
David Anderson
3195dec436
Split LoadOrRequireExtensions into two distinct functions.
2015-09-20 23:44:45 -07:00
David Anderson
15f4a05122
Factor the iterator out of LoadOrRequireExtensions.
2015-09-20 23:44:41 -07:00
David Anderson
e559e6ffa8
Simplify pass 2 of LoadOrRequireExtensions.
2015-09-20 23:44:37 -07:00
David Anderson
23290b35a7
Clean up LoadOrRequireExtensions and properly scope variables.
2015-09-20 23:44:34 -07:00
David Anderson
2b3da56fb5
Dedent a huge block of code.
2015-09-20 23:44:30 -07:00
David Anderson
370710c0ff
Fix build.
2015-09-20 21:39:12 -07:00
David Anderson
4fc7eb8a6b
Remove trailing whitespace.
2015-09-20 20:58:03 -07:00
David Anderson
38c01714d7
Clean up AskPluginLoad logic.
2015-09-20 20:57:59 -07:00
David Anderson
0e1a34a4d7
Hide CPlugin timestamp management details.
2015-09-20 20:57:55 -07:00
David Anderson
d5d7e8c9cf
Factor guts of _LoadPlugin into a separate function.
2015-09-20 20:57:51 -07:00
David Anderson
76d681761d
Factor malware checks into its own pass.
2015-09-20 20:57:47 -07:00
David Anderson
3807edbeb8
Move CPlugin compilation into its own function.
2015-09-20 20:57:43 -07:00
David Anderson
d9216cc599
Remove references to non-mapupdated plugins.
2015-09-20 20:31:30 -07:00
David Anderson
8a7dfdbc11
Move the "sm" command to core/logic.
2015-09-20 14:33:17 -07:00
David Anderson
168b779786
Move sm_dump_handles to core/logic.
2015-09-20 14:33:10 -07:00
David Anderson
c853050265
Move sm_reload_translations to Translator.
2015-09-20 14:33:06 -07:00
David Anderson
c614d19af0
Move sm_dump_admcache to AdminCache.
2015-09-20 14:33:02 -07:00
David Anderson
c36f80b93d
Don't use server commands to flush plugin unloads.
2015-09-15 19:43:41 -07:00
David Anderson
d473b0441d
Allow plugin info fields to outlive their runtime.
2015-09-15 19:07:22 -07:00
David Anderson
2adae27557
Clean up CPlugin member variables.
2015-09-14 12:55:42 -07:00
David Anderson
3430962cbe
Simplify required libs handling and make sure they create dependency links.
2015-09-14 12:53:23 -07:00
David Anderson
0aaa659e29
Fix how the mark-serial is used.
...
The mark-serial is a generation number to optimize dependency tracking. It did not actually get
applied correctly, meaning that in rare cases we could miss dependencies. This patch removes the
incorrect serial propagation and ensures that we don't double-count a dependent plugin.
Additionally, this patch ensures that all callers of BindNativeToPlugin() will update the mark
serial, as is required to correctly track dependencies.
2015-09-14 12:50:50 -07:00
David Anderson
9ef8cc7064
Separate the top of UnloadPlugin into a precursor function.
2015-09-14 12:50:39 -07:00
David Anderson
67c8ee4ce3
Move CDataPack from core to logic.
2015-09-06 11:02:52 -07:00
David Anderson
4e275eea97
Split intercom.h into separate headers and reduce shared header inclusion.
2015-08-31 10:00:49 -07:00
David Anderson
4f1705e001
Rename some bridge interfaces.
2015-08-31 09:57:32 -07:00
David Anderson
5d55ff23bd
Move OnQueryCvarValueFinished into the global hook manager.
2015-08-31 09:22:08 -07:00
David Anderson
401aa038f8
Start a new bridge mechanism for global callbacks.
2015-08-31 00:07:27 -07:00
David Anderson
38e1c2f1f3
Clean up the core side of the logic bridge.
2015-08-30 23:30:15 -07:00
David Anderson
9e4d396d5e
Virtualize MMS functions in the core/logic bridge.
2015-08-30 23:29:46 -07:00
David Anderson
5c5d43137d
Virtualize game state functions in the core/logic bridge.
2015-08-30 23:29:23 -07:00
David Anderson
bdfdab1d3a
Virtualize game description functions in the core/logic bridge.
2015-08-30 23:28:59 -07:00
David Anderson
9366882ac4
Virtualize ConVar bridge functions.
2015-08-30 23:28:44 -07:00
David Anderson
0f9e5234fe
Convert core_bridge to a proper class declaration.
2015-08-30 23:28:28 -07:00
David Anderson
3d5c9f0e21
Rename smcore to bridge, and use it as a pointer.
2015-08-30 23:27:53 -07:00
David Anderson
a2dac43833
Remove CCommand from the logic bridge.
2015-08-30 21:02:14 -07:00
David Anderson
28346c99f2
Move RootConsoleMenu into core/logic.
2015-08-30 21:01:46 -07:00
David Anderson
23d55dd9d5
Move RootConsoleMenu::ConsolePrint into the logic bridge.
2015-08-30 21:01:27 -07:00
David Anderson
9d805ea9fb
Replace the AddRootConsoleCommand API to not expose internal structures.
2015-08-30 21:01:03 -07:00
David Anderson
6503e92d66
Move LibrarySys from core to logic.
2015-08-30 20:11:22 -07:00
David Anderson
e78fe93e92
Move gnprintf/atcprintf from core to logic.
2015-08-30 19:32:46 -07:00
David Anderson
9d2bee261c
Move TrimWhitespace from core to logic.
2015-08-30 18:42:25 -07:00
David Anderson
a158205f30
Remove strncopy from the core/logic bridge.
2015-08-30 18:21:07 -07:00
David Anderson
9ba1363d86
Remove Format/FormatArgs from the core/logic bridge.
2015-08-30 18:03:31 -07:00
David Anderson
c87b3c0859
Update to the latest AMTL version.
2015-08-27 01:01:18 -04:00
David Anderson
e30b57cb4a
Update build scripts for new AMTL folder structure.
2015-08-26 15:54:55 -04:00
Nicholas Hastings
af4573e7af
Fix build on Clang.
2015-08-14 08:31:52 -04:00
Nicholas Hastings
a08a693bf3
Make path id default to "GAME" instead of NULL for FileExists and FileSize if param missing.
...
This only affects plugins compiled before the param existed in the includes. NULL defaults to "GAME"
on some engine versions, but is invalid on others, causing any file to not be found.
2015-08-14 07:52:50 -04:00
David Anderson
ff692f6040
Merge pull request #366 from peace-maker/timer_paused
...
Fix calling timer callback in paused plugins
2015-08-13 22:14:02 -07:00
David Anderson
bcfef75c5d
Update regex and datapack includes to not use binding syntax.
2015-08-12 11:52:57 -07:00
Peace-Maker
0a14d3f50c
Fix calling timer callback in paused plugins
...
Don't try to call the timer callback, if it's not runnable.
Error wasn't reported before the exception refactoring.
2015-08-09 01:50:36 +02:00
Asher Baker
705b5d3f5f
Merge pull request #340 from asherkin/datapack-alloc
...
Improve DataPack memory allocation & Report size for DataPack Handles
2015-07-08 20:07:40 +01:00
Nicholas Hastings
c0d4dfa6ed
Update IsMapValid for today's TF2 update.
2015-06-11 17:48:58 -04:00
Nicholas Hastings
14e0a9a487
Fix some ctype misuses (bug 6377).
...
isalpha, isdigit, isupper, and islower do not return 0/1. They return 0 or anything-else. Since the bool tag in pawn only supports exactly 0 and 1, we need to return 1 for all truthy returns in the natives that wrap these.
2015-06-10 14:40:48 -04:00
Nicholas Hastings
2abb8e6335
Remove engine check for whether or not to search alt mapcycle paths.
2015-05-18 09:16:36 -04:00
Asher Baker
fd48f4adfd
Report size for DataPack Handles.
2015-05-13 19:43:53 +01:00
Nicholas Hastings
11bf32f6f1
Enable finding mapcycle in cfg dir on sdk2013 and bms.
2015-05-13 06:49:37 -07:00
Ryan Stecker
03e0c7317d
Notify plugin listeners of SetFailState'd plugins on unload. (bug 6347)
2015-04-12 19:25:07 -05:00
Kyle Sanderson
88c4618230
Merge pull request #320 from KyleSanderson/dust
...
Remove Project Files from older outdated build systems.
2015-04-02 10:34:57 -07:00
Kyle Sanderson
7341bd184e
Remove Project Files from older outdated build systems.
2015-04-01 19:54:34 -07:00
Nicholas Hastings
7b56dd5c8a
Fix build.
2015-03-22 19:23:58 -04:00
Nicholas Hastings
28870d2ae5
Make OpenDirectory error for empty path match error in DirExists.
2015-03-10 18:58:00 -07:00
Nicholas Hastings
cc3b86ea80
Throw an error if DirExists called with empty path.
2015-03-10 18:57:28 -07:00
David Anderson
eaea3c927d
Update upstream AMTL as a submodule.
2015-03-08 00:24:03 -08:00
David Anderson
561004c4bf
Move SourcePawn headers out of public/ into sourcepawn/include.
2015-03-07 11:13:32 -08:00
Nicholas Hastings
6f8ffd55a7
Merge pull request #263 from alliedmodders/admins-trans
...
Update admins.inc with methodmaps, newdecls (r=dvander, asherkin).
2015-03-05 14:32:15 -05:00
Nicholas Hastings
70390ff1f7
Purge Purge.
2015-03-05 10:56:36 -08:00
David Anderson
a1afa23bc4
Implement a new stack and error handling model for the SourcePawn VM.
...
This has three major changes to SourcePawn. First, the API now supports the concept of "exceptions". The exception state is a global property of an instance of the SourcePawn VM. Exceptions can be caught or suppressed. Many places in SourceMod have been updated to check exceptions instead of errors.
The new API obsoletes major parts of the embedder API - all but one method of invoking functions is obsoleted, and the debug interface has been scrapped. Extensions using the native API will not be affected, however, ThrowNativeError has been deprecated in favor of ReportError.
Second, the SourcePawn concept of a "stack" has been unified at the API level. A stack frame iterator now iterates over all SourcePawn invocations, rather than the topmost plugin. This makes error handling more consistent and removes another dependency on context-per-plugin.
Finally, the implementation of stack frames has been changed dramatically. Rather than maintain a complicated and expensive return pointer stack, we now rely on the implicit one provided by the CPU. The stack frame iterator now walks the JIT stack directly. This removes many unnecessary bookkeeping instructions from the generated code, in particular making the CALL instruction 40% faster.
These changes required some fair surgery to the JIT. Its error paths are now slightly more complicated, as they have to throw an exception rather than return an error code. In addition, any path that can throw an exception is now responsible for creating an "exit frame", which exists to tell the stack frame iterator about transitions from the JIT to the VM.
2015-03-04 23:45:30 -08:00
David Anderson
04827466b0
Rewrite the .smx parser.
...
This removes one the last remnants of the SourceMod 1.0 VM implementation.
The new parser introduces a number of design changes in the VM. First, the VM now takes greater responsibility for validating and sanity checking the structure of the SMX container format. Previously, malformed SMX files could easily crash SourcePawn. The loader now rejects files that have out-of-bounds offsets or incomplete sections. Complex sections, like debug info or the code stream, are verified lazily.
Internally, the sp_plugin_t structure has been removed. It has been replaced by a new LegacyImage class, designed to be independent from the SPVM API. This potentially lets us load code streams from non-.smx containers. More importantly, it removes a lot of bookkeeping and pre-computed state from PluginRuntime. The LegacyImage class is now responsible for handling debug info as well.
PluginRuntime is now intended to hold only cached or immutable data, and PluginContext holds all VM state. As such PluginContext is now responsible for allocating a plugin's runtime memory, not PluginRuntime.
Finally, some aspects of the loading process have been cleaned up. The
decompression and image handoff logic should now be easier to
understand.
2015-02-25 22:28:10 -08:00
David Anderson
fcaa5361c8
Don't expose mutable sp_native_t.
2015-02-24 23:10:18 -08:00
Asher Baker
6572989993
Merge pull request #213 from splewis/find-array-nonzero-blocks
...
Add block parameter to FindValueInArray native.
2015-02-24 22:37:49 +00:00
David Anderson
21f5400d9c
Remove ICompilationData.
2015-02-24 02:03:57 -08:00
Nicholas Hastings
b9579a53ce
Add missing impl for File.ReadUint16.
2015-02-18 04:50:20 -08:00
Nicholas Hastings
c0729ff5e2
Add methodmap for GroupId.
2015-02-17 08:21:14 -08:00
Nicholas Hastings
c2d37cdff5
Add methmodmap for AdminId.
2015-02-17 07:19:56 -08:00
Nicholas Hastings
0f00a2db08
Remove unused result value in OnRebuildAdminCache forward call.
2015-02-17 06:43:49 -08:00
Nicholas Hastings
e88039d4e0
Fix FindFlagChar not finding char for AdminFlag_Custom6.
2015-02-03 10:32:34 -05:00
Nicholas Hastings
84a59c6fb7
Fix g_ReverseFlags array size.
2015-02-03 10:27:32 -05:00
Nicholas Hastings
19be28cc2e
Rename g_FlagSet to g_FlagCharSet to avoid some confusion.
2015-02-03 10:26:28 -05:00
Nicholas Hastings
52514a96bd
Fix "sm plugins refresh" not refreshing changed plugins.
2015-01-31 15:28:21 -05:00
Nicholas Hastings
8705aea634
Fix signed/unsigned compare warning in smn_adt_stack.
2015-01-27 17:59:55 -08:00
David Anderson
3040708d4e
Merge pull request #215 from Thordin/more_handles
...
Increased handles to 32k
2015-01-26 11:24:46 -08:00
David Anderson
2382902fe4
Merge pull request #244 from alliedmodders/db-fix
...
Fix wrong value in transitional DBI callback. (bug 6292)
2015-01-23 14:07:22 -08:00
Nicholas Hastings
9f648879e5
Fix regression causing "BOT" to no longer be valid in adminsys for Steam identities.
2015-01-17 10:11:04 -05:00
David Anderson
49383e7391
Fix wrong value in transitional DBI callback. (bug 6292)
2015-01-16 00:33:29 -08:00
Nicholas Hastings
3929ff1f27
Fix typo on ArrayList.Erase native.
2015-01-04 11:58:44 -05:00
Peace-Maker
9b2e77711a
Plugin_Failed == "An unrecoverable error"
...
Change the meaning of Plugin_Failed status to indicate, that the plugin
can't recover from the error.
Make sure those previously loaded plugins are shown correctly in sm
plugins info x.
2014-12-20 11:08:30 +01:00
Peace-Maker
0b131d6864
Pause dependent plugins on SetFailState (bug 6120)
...
When a plugin calls SetFailState it is paused and all natives it
registered are unavailable. Other plugins, which depend on those natives
keep running and error whenever they try to call those natives.
This correctly sets the dependent plugins to an error state as if the
plugin which called SetFailState was unloaded.
2014-12-20 11:07:57 +01:00
David Anderson
b1cb06c5ce
Update DBI for transitional syntax.
2014-12-13 16:34:58 -08:00
David Anderson
722a23c818
Redo menu methodmaps.
2014-12-13 12:53:30 -08:00
Thordin
f27c33cd18
Increased handles to 32k
2014-12-07 21:50:40 -08:00
Sean Lewis
d2e01da287
Wrap 3rd parameter in FindValueInArray to check for existence.
2014-12-06 17:07:54 -06:00
Sean Lewis
3ef2bdcb8d
Add block parameter to FindValueInArray native.
2014-12-06 03:21:53 -06:00
Asher Baker
50898d7a4f
Merge pull request #208 from asherkin/long-lang-codes
...
Support long key names for languages (bug 6282)
2014-11-24 19:07:18 +00:00
Asher Baker
ced026cecc
Support long key names for languages. (bug 6282)
2014-11-22 22:18:49 +00:00
David Anderson
be6da2f810
Merge pull request #173 from alliedmodders/tr-smc
...
Port SMC parsing API to transitional syntax.
2014-11-19 22:38:19 -08:00
David Anderson
0511543c76
Merge pull request #206 from alliedmodders/tr-files
...
Port files.inc to transitional syntax.
2014-11-18 18:56:07 -08:00
Nicholas Hastings
50400cf029
Remove unused variables.
2014-11-15 19:35:47 -05:00
David Anderson
79143d8b6e
Port files.inc to transitional syntax.
2014-11-15 13:42:28 -08:00
David Anderson
f25953bb6c
Merge pull request #187 from alliedmodders/tr-arrays
...
Update ArrayList for transitional syntax.
2014-11-15 13:04:29 -08:00
David Anderson
461dc3af3d
Merge pull request #189 from alliedmodders/tr-tries
...
Port string maps to transitional syntax.
2014-11-15 12:52:37 -08:00
David Anderson
4cb29eb054
Port adt_stack to transitional syntax.
2014-11-15 12:46:17 -08:00
David Anderson
8479c2f067
Port SMC parsing API to transitional syntax.
2014-11-09 12:33:07 -08:00
David Anderson
6ba4bcb955
Port string maps to transitional syntax.
2014-11-08 17:43:28 -08:00
David Anderson
919a31df57
Update ArrayList for transitional syntax.
2014-11-08 16:31:33 -08:00
David Anderson
f16501d34a
Simplify filesystem native implementation.
2014-11-08 15:44:35 -08:00
Nicholas Hastings
9021b23bc2
Fix crash on OpenDirectory with use_valve_fs if path not found.
...
Also fixes minor memory leak on bad path.
2014-10-28 13:57:40 -04:00
Nicholas Hastings
dca15ebabf
Fix OpenDirectory with use_valve_fs requirement of trailing slash.
2014-10-28 13:53:27 -04:00
Nicholas Hastings
512fae4c25
Fix crash on Windows when dumping admin cache to file.
2014-10-08 17:31:02 -07:00
Nicholas Hastings
0f6063af60
Re-add DBI query throttling (r=dvander).
2014-09-18 22:02:32 -04:00
Nicholas Hastings
c62e7458f9
Disable RTTI for Loader, Logic, and JIT bins
2014-09-11 17:15:59 -07:00
Nicholas Hastings
e6fd19fb8c
Fix crash regression from typo in 892edd9650
2014-09-09 22:05:59 -04:00
Nicholas Hastings
a597277a64
Merge pull request #153 from alliedmodders/auth-fixups
...
More auth fixups for Steam auth (bug 6243, r=asherkin).
2014-09-09 16:24:57 -04:00
Nicholas Hastings
b3dada65fa
Fix build.
2014-09-09 13:21:01 -07:00
Nicholas Hastings
ad7d920ce0
Move menu natives from core to logic
2014-09-05 08:24:40 -07:00
Nicholas Hastings
1bf4eb80bd
Cache Steam ID and rendered forms when caching networkID
2014-09-04 16:14:34 -07:00
Nicholas Hastings
f1dc24c089
Move Steam2/3 id rendering logic to CPlayer
2014-09-04 15:27:44 -07:00
Nicholas Hastings
892edd9650
Allow BindIdentity and FindAdminByIdentity to take more SteamID formats for steam auth type
2014-09-04 15:26:12 -07:00
David Anderson
a1dc1101f7
Fix build.
2014-09-03 22:33:05 -07:00
Nicholas Hastings
7f3656215b
Consistency Fixes (ID->Id, AuthString->AuthId)
2014-09-03 15:13:30 -07:00
Nicholas Hastings
3fba1d2817
Fix some nits
2014-09-03 10:50:11 -07:00
