UNLOZE/sourcemod
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix uninit'd memory issues in AMTL AString and Vector (bug 5921, r=psychonic).

Browse Source 
--HG--
extra : rebase_source : 17a57dcf815cb3798eaa13af5f4af44fb1930f86
This commit is contained in:
Kyle Sanderson 2013-11-30 10:59:05 -05:00
parent f0e4fe66ba
commit 398b05afed
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
public/amtl/am-string.h
View File

@ -55,6 +55,8 @@ class AString
AString(const AString &other) { AString(const AString &other) {
if (other.length_) if (other.length_)
set(other.chars_, other.length_); set(other.chars_, other.length_);
else
length_ = 0;
} }
AString(Moveable<AString> other) AString(Moveable<AString> other)
: chars_(other->chars_.take()), : chars_(other->chars_.take()),

6
public/amtl/am-vector.h
View File

@ -187,10 +187,10 @@ class Vector : public AllocPolicy
bool moveUp(size_t at) { bool moveUp(size_t at) {
assert(at < nitems_); assert(at < nitems_);
if (!growIfNeeded(1)) if (!append(Moveable<T>(data_[nitems_ - 1])))
return false; return false;
nitems_++;
for (size_t i = nitems_ - 1; i > at; i--) for (size_t i = nitems_ - 2; i > at; i--)
data_[i] = Moveable<T>(data_[i - 1]); data_[i] = Moveable<T>(data_[i - 1]);
return true; return true;
} }