UNLOZE/sourcemod
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Increase topmenu display buffer size (#520)

Browse Source 
The buffer for menu options was 64 chars. That limit can easily be
reached by some utf8 string which would get truncated. Double the buffer
size to 128 chars.
This commit is contained in:
peace-maker 2016-06-20 17:03:54 +02:00 committed by Asher Baker
parent 023a3ca056
commit f425236bac
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
extensions/topmenus/TopMenu.cpp
View File

@ -36,7 +36,7 @@
struct obj_by_name_t struct obj_by_name_t
{ {
unsigned int obj_index; unsigned int obj_index;
char name[64]; char name[TOPMENU_DISPLAY_BUFFER_SIZE];
}; };
int _SortObjectNamesDescending(const void *ptr1, const void *ptr2); int _SortObjectNamesDescending(const void *ptr1, const void *ptr2);
@ -667,7 +667,7 @@ unsigned int TopMenu::OnMenuDisplayItem(IBaseMenu *menu,
return 0; return 0;
/* Ask the object to render the text for this client */ /* Ask the object to render the text for this client */
char renderbuf[64]; char renderbuf[TOPMENU_DISPLAY_BUFFER_SIZE];
obj->callbacks->OnTopMenuDisplayOption(this, client, obj->object_id, renderbuf, sizeof(renderbuf)); obj->callbacks->OnTopMenuDisplayOption(this, client, obj->object_id, renderbuf, sizeof(renderbuf));
/* Build the new draw info */ /* Build the new draw info */

2
extensions/topmenus/TopMenu.h
View File

@ -42,6 +42,8 @@
using namespace SourceHook; using namespace SourceHook;
using namespace SourceMod; using namespace SourceMod;
#define TOPMENU_DISPLAY_BUFFER_SIZE 128
struct config_category_t struct config_category_t
{ {
int name; int name;