Individualize NameHashSet Hashing & Revisit #709 (#740) (1.9-dev) (#866)

This is a clone of #740, but without the amtl ke::AString lowercase which was implemented in a new version of amtl that 1.9-dev isn't pinned to. Updating this pin and moving fixes is beyond what should go in 1.9, and this fixes a annoying and user-impactful bug with reload/unloading plugins on windows.

Currently in 1.9, once a plugin is loaded into the pluginsys, they must be used with lowercase characters *only*, since pr #709 ignorantly modified their names. 

```
// test.smx exists in /plugins/
sm plugins load TEST.smx // successful
sm plugins unload TEST.smx // TEST.smx not found, it's actually test.smx
```

This pr fixes that error by converting *all* lookups, not just loads.

This commit is contained in:

Michael Flaherty

2018-08-11 13:37:05 +01:00

committed by

Asher Baker

parent c6303d1ec3

commit dd456dcb19

15 changed files with 117 additions and 40 deletions

									
										extensions/topmenus/TopMenu.h
									
		+4
		
												View File
												
				@@ -77,6 +77,10 @@ struct topmenu_object_t

					{

						return strcmp(name, topmenu->name) == 0;

					}

					static inline uint32_t hash(const detail::CharsAndLength &key)

					{

						return key.hash();

					}

				};

				struct topmenu_category_t