UNLOZE/sourcemod
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix threaded query's result handle access rights (#567)

Browse Source 
Plugins were able to close the results handle in the threaded query
callback causing a double free crash. The access rights are setup right
before the handle is created, but weren't used.
This commit is contained in:
peace-maker 2016-12-11 17:35:53 -07:00 committed by Kyle Sanderson
parent 71788e2325
commit d3d16a93cf
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
core/logic/smn_database.cpp
View File

@ -250,9 +250,6 @@ public:
{ {
/* Create a Handle for our query */ /* Create a Handle for our query */
HandleSecurity sec(me->GetIdentity(), g_pCoreIdent); HandleSecurity sec(me->GetIdentity(), g_pCoreIdent);
HandleAccess access;
handlesys->InitAccessDefaults(NULL, &access);
access.access[HandleAccess_Delete] = HANDLE_RESTRICT_IDENTITY|HANDLE_RESTRICT_OWNER;
Handle_t qh = BAD_HANDLE; Handle_t qh = BAD_HANDLE;
@ -260,7 +257,7 @@ public:
{ {
CombinedQuery *c = new CombinedQuery(m_pQuery, m_pDatabase); CombinedQuery *c = new CombinedQuery(m_pQuery, m_pDatabase);
qh = handlesys->CreateHandle(hCombinedQueryType, c, me->GetIdentity(), g_pCoreIdent, NULL); qh = CreateLocalHandle(hCombinedQueryType, c, &sec);
if (qh != BAD_HANDLE) if (qh != BAD_HANDLE)
{ {
m_pQuery = NULL; m_pQuery = NULL;