UNLOZE/sourcemod
9
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Burninate IDataPack (#864)

Browse Source 
This doesn't break any extensions NOT using IDataPack, and we do not know of any that are.

* The extension storage utility of this interface has been broken for the last 9 months, with ISourceMod::CreateDataPack being disabled.
* The plugin interop utility of this interface (its stated purpose) has been broken for the last 11+ years, with ISourceMod::GetDataPackHandleType being disabled.

I imagine it only survived the first cleanup 11 years ago because CSS:DM was using it internally, which it has now been migrated away from.

Compiled all the included extensions without changes (API compat), and loaded extensions build pre-change without issue (ABI compat).
This commit is contained in:
Asher Baker
2018-08-13 23:03:48 +01:00
committed by GitHub
parent 144fb907f1
commit ba8b42ef1b
10 changed files with 121 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/sourcemod.cpp
+3 -3
View File
@@ -617,14 +617,14 @@ unsigned int SourceModBase::GetGlobalTarget() const
return m_target;
}
IDataPack *SourceModBase::CreateDataPack()
void *SourceModBase::CreateDataPack()
{
return nullptr;
}
void SourceModBase::FreeDataPack(IDataPack *pack)
void SourceModBase::FreeDataPack(void *pack)
{
logicore.FreeDataPack(pack);
return;
}
Handle_t SourceModBase::GetDataPackHandleType(bool readonly)