UNLOZE/sourcemod
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix inconsistencies with buffer sizes for player names.

Browse Source 
Found any I could not using MAX_NAME_LENGTH and changed them to use it. I think that we should
increase MAX_NAME_LENGTH to 128 for CS:GO at some point as that's what it uses internally.
(Presumably to get the client's full multibyte name from Steam without truncation mid-codepoint which
can happen in other games. Steam's max is 32 characters if I remember correctly, but allows multibyte chars).
This commit is contained in:
Nicholas Hastings 2015-06-03 22:40:43 -04:00
parent 5139eef183
commit 9e0dbfcf68
16 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/admin-sql-threaded.sp
View File

@ -457,8 +457,8 @@ public void OnReceiveUser(Database db, DBResultSet rs, const char[] error, any d
void FetchUser(Database db, int client) void FetchUser(Database db, int client)
{ {
char name[65]; char name[MAX_NAME_LENGTH];
char safe_name[140]; char safe_name[(MAX_NAME_LENGTH * 2) - 1];
char steamid[32]; char steamid[32];
char steamidalt[32]; char steamidalt[32];
char ipaddr[24]; char ipaddr[24];

2
plugins/basebans/ban.sp
View File

@ -49,7 +49,7 @@ PrepareBan(client, target, time, const String:reason[])
return; return;
} }
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
if (!time) if (!time)

2
plugins/funcommands/beacon.sp
View File

@ -184,7 +184,7 @@ public MenuHandler_Beacon(Menu menu, MenuAction action, int param1, int param2)
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformBeacon(param1, target); PerformBeacon(param1, target);

2
plugins/funcommands/blind.sp
View File

@ -208,7 +208,7 @@ public MenuHandler_Amount(Menu menu, MenuAction action, int param1, int param2)
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformBlind(param1, target, amount); PerformBlind(param1, target, amount);

2
plugins/funcommands/drug.sp
View File

@ -265,7 +265,7 @@ public MenuHandler_Drug(Menu menu, MenuAction action, int param1, int param2)
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformDrug(param1, target, 2); PerformDrug(param1, target, 2);

6
plugins/funcommands/fire.sp
View File

@ -125,7 +125,7 @@ public Action:Timer_FireBomb(Handle:timer, any:value)
SetEntityRenderColor(client, 255, color, color, 255); SetEntityRenderColor(client, 255, color, color, 255);
char name[64]; char name[MAX_NAME_LENGTH];
GetClientName(client, name, sizeof(name)); GetClientName(client, name, sizeof(name));
PrintCenterTextAll("%t", "Till Explodes", name, g_FireBombTime[client]); PrintCenterTextAll("%t", "Till Explodes", name, g_FireBombTime[client]);
@ -304,7 +304,7 @@ public MenuHandler_Burn(Menu menu, MenuAction action, int param1, int param2)
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformBurn(param1, target, 20.0); PerformBurn(param1, target, 20.0);
ShowActivity2(param1, "[SM] ", "%t", "Set target on fire", "_s", name); ShowActivity2(param1, "[SM] ", "%t", "Set target on fire", "_s", name);
@ -349,7 +349,7 @@ public MenuHandler_FireBomb(Menu menu, MenuAction action, int param1, int param2
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformFireBomb(param1, target); PerformFireBomb(param1, target);

2
plugins/funcommands/gravity.sp
View File

@ -165,7 +165,7 @@ public MenuHandler_GravityAmount(Menu menu, MenuAction action, int param1, int p
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformGravity(param1, target, amount); PerformGravity(param1, target, amount);

6
plugins/funcommands/ice.sp
View File

@ -246,7 +246,7 @@ public Action:Timer_FreezeBomb(Handle:timer, any:value)
SetEntityRenderColor(client, color, color, 255, 255); SetEntityRenderColor(client, color, color, 255, 255);
char name[64]; char name[MAX_NAME_LENGTH];
GetClientName(client, name, sizeof(name)); GetClientName(client, name, sizeof(name));
PrintCenterTextAll("%t", "Till Explodes", name, g_FreezeBombTime[client]); PrintCenterTextAll("%t", "Till Explodes", name, g_FreezeBombTime[client]);
@ -418,7 +418,7 @@ public MenuHandler_Freeze(Menu menu, MenuAction action, int param1, int param2)
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformFreeze(param1, target, g_Cvar_FreezeDuration.IntValue); PerformFreeze(param1, target, g_Cvar_FreezeDuration.IntValue);
@ -464,7 +464,7 @@ public MenuHandler_FreezeBomb(Menu menu, MenuAction action, int param1, int para
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformFreezeBomb(param1, target); PerformFreezeBomb(param1, target);

2
plugins/funcommands/noclip.sp
View File

@ -109,7 +109,7 @@ public MenuHandler_NoClip(Menu menu, MenuAction action, int param1, int param2)
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformNoClip(param1, target); PerformNoClip(param1, target);

4
plugins/funcommands/timebomb.sp
View File

@ -118,7 +118,7 @@ public Action:Timer_TimeBomb(Handle:timer, any:value)
SetEntityRenderColor(client, 255, 128, color, 255); SetEntityRenderColor(client, 255, 128, color, 255);
char name[64]; char name[MAX_NAME_LENGTH];
GetClientName(client, name, sizeof(name)); GetClientName(client, name, sizeof(name));
PrintCenterTextAll("%t", "Till Explodes", name, g_TimeBombTime[client]); PrintCenterTextAll("%t", "Till Explodes", name, g_TimeBombTime[client]);
@ -275,7 +275,7 @@ public MenuHandler_TimeBomb(Menu menu, MenuAction action, int param1, int param2
} }
else else
{ {
new String:name[32]; new String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformTimeBomb(param1, target); PerformTimeBomb(param1, target);

2
plugins/funvotes.sp
View File

@ -283,7 +283,7 @@ VoteSelect(Handle:menu, param1, param2 = 0)
{ {
if (GetConVarInt(g_Cvar_VoteShow) == 1) if (GetConVarInt(g_Cvar_VoteShow) == 1)
{ {
decl String:voter[64], String:junk[64], String:choice[64]; decl String:voter[MAX_NAME_LENGTH], String:junk[64], String:choice[64];
GetClientName(param1, voter, sizeof(voter)); GetClientName(param1, voter, sizeof(voter));
menu.GetItem(param2, junk, sizeof(junk), _, choice, sizeof(choice)); menu.GetItem(param2, junk, sizeof(junk), _, choice, sizeof(choice));
PrintToChatAll("[SM] %T", "Vote Select", LANG_SERVER, voter, choice); PrintToChatAll("[SM] %T", "Vote Select", LANG_SERVER, voter, choice);

6
plugins/include/helpers.inc
View File

@ -46,7 +46,7 @@
stock FormatUserLogText(client, String:buffer[], maxlength) stock FormatUserLogText(client, String:buffer[], maxlength)
{ {
decl String:auth[32]; decl String:auth[32];
decl String:name[40]; decl String:name[MAX_NAME_LENGTH];
new userid = GetClientUserId(client); new userid = GetClientUserId(client);
if (!GetClientAuthString(client, auth, sizeof(auth))) if (!GetClientAuthString(client, auth, sizeof(auth)))
@ -107,7 +107,7 @@ stock int SearchForClients(const char[] pattern, int[] clients, int maxClients)
if (pattern[0] == '#') { if (pattern[0] == '#') {
int input = StringToInt(pattern[1]); int input = StringToInt(pattern[1]);
if (!input) { if (!input) {
char name[65]; char name[MAX_NAME_LENGTH];
for (int i=1; i<=MaxClients; i++) { for (int i=1; i<=MaxClients; i++) {
if (!IsClientInGame(i)) if (!IsClientInGame(i))
continue; continue;
@ -126,7 +126,7 @@ stock int SearchForClients(const char[] pattern, int[] clients, int maxClients)
} }
} }
char name[65]; char name[MAX_NAME_LENGTH];
for (int i=1; i<=MaxClients; i++) for (int i=1; i<=MaxClients; i++)
{ {
if (!IsClientInGame(i)) if (!IsClientInGame(i))

6
plugins/nominations.sp
View File

@ -234,7 +234,7 @@ public Action Command_Nominate(int client, int args)
g_mapTrie.SetValue(mapname, MAPSTATUS_DISABLED|MAPSTATUS_EXCLUDE_NOMINATED); g_mapTrie.SetValue(mapname, MAPSTATUS_DISABLED|MAPSTATUS_EXCLUDE_NOMINATED);
char name[64]; char name[MAX_NAME_LENGTH];
GetClientName(client, name, sizeof(name)); GetClientName(client, name, sizeof(name));
PrintToChatAll("[SM] %t", "Map Nominated", name, mapname); PrintToChatAll("[SM] %t", "Map Nominated", name, mapname);
@ -312,10 +312,10 @@ public int Handler_MapSelectMenu(Menu menu, MenuAction action, int param1, int p
{ {
case MenuAction_Select: case MenuAction_Select:
{ {
char map[PLATFORM_MAX_PATH], name[64]; char map[PLATFORM_MAX_PATH], name[MAX_NAME_LENGTH];
menu.GetItem(param2, map, sizeof(map)); menu.GetItem(param2, map, sizeof(map));
GetClientName(param1, name, 64); GetClientName(param1, name, sizeof(name));
NominateResult result = NominateMap(map, false, param1); NominateResult result = NominateMap(map, false, param1);

2
plugins/playercommands/slap.sp
View File

@ -149,7 +149,7 @@ public MenuHandler_Slap(Menu menu, MenuAction action, int param1, int param2)
} }
else else
{ {
decl String:name[32]; decl String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformSlap(param1, target, g_SlapDamage[param1]); PerformSlap(param1, target, g_SlapDamage[param1]);
ShowActivity2(param1, "[SM] ", "%t", "Slapped target", "_s", name); ShowActivity2(param1, "[SM] ", "%t", "Slapped target", "_s", name);

2
plugins/playercommands/slay.sp
View File

@ -103,7 +103,7 @@ public MenuHandler_Slay(Menu menu, MenuAction action, param1, param2)
} }
else else
{ {
decl String:name[32]; decl String:name[MAX_NAME_LENGTH];
GetClientName(target, name, sizeof(name)); GetClientName(target, name, sizeof(name));
PerformSlay(param1, target); PerformSlay(param1, target);
ShowActivity2(param1, "[SM] ", "%t", "Slayed target", "_s", name); ShowActivity2(param1, "[SM] ", "%t", "Slayed target", "_s", name);

2
plugins/rockthevote.sp
View File

@ -210,7 +210,7 @@ AttemptRTV(client)
return; return;
} }
new String:name[64]; new String:name[MAX_NAME_LENGTH];
GetClientName(client, name, sizeof(name)); GetClientName(client, name, sizeof(name));
g_Votes++; g_Votes++;