UNLOZE/sourcemod
10
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up AskPluginLoad logic.

Browse Source
This commit is contained in:
David Anderson 2015-09-16 21:40:13 -07:00
parent 0e1a34a4d7
commit 38c01714d7
1 changed files with 25 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
core/logic/PluginSys.cpp
View File

@ -917,34 +917,32 @@ LoadRes CPluginManager::LoadPlugin(CPlugin **aResult, const char *path, bool deb
CPlugin *plugin = CompileAndPrep(path, error, maxlength); CPlugin *plugin = CompileAndPrep(path, error, maxlength);
LoadRes loadFailure = LoadRes_Failure; // Assign our outparam so we can return early. It must be set.
/* Get the status */ *aResult = plugin;
if (pPlugin->GetStatus() == Plugin_Created) {
APLRes result = pPlugin->Call_AskPluginLoad(error, maxlength); if (plugin->GetStatus() != Plugin_Created)
switch (result) return LoadRes_Failure;
{
case APLRes_Success: APLRes result = plugin->Call_AskPluginLoad(error, maxlength);
/* Autoload any modules */ switch (result)
LoadOrRequireExtensions(pPlugin, 1, error, maxlength); {
break; case APLRes_Success:
case APLRes_Failure: if (!LoadOrRequireExtensions(plugin, 1, error, maxlength))
pPlugin->SetErrorState(Plugin_Failed, "%s", error); return LoadRes_Failure;
loadFailure = LoadRes_Failure; return LoadRes_Successful;
break;
case APLRes_SilentFailure: case APLRes_Failure:
pPlugin->SetErrorState(Plugin_Failed, "%s", error); plugin->SetErrorState(Plugin_Failed, "%s", error);
loadFailure = LoadRes_SilentFailure; return LoadRes_Failure;
pPlugin->SetSilentlyFailed();
break; case APLRes_SilentFailure:
default: plugin->SetErrorState(Plugin_Failed, "%s", error);
assert(false); plugin->SetSilentlyFailed();
} return LoadRes_SilentFailure;
default:
return LoadRes_Failure;
} }
if (aResult)
*aResult = pPlugin;
return (pPlugin->GetStatus() == Plugin_Loaded) ? LoadRes_Successful : loadFailure;
} }
IPlugin *CPluginManager::LoadPlugin(const char *path, bool debug, PluginType type, char error[], size_t maxlength, bool *wasloaded) IPlugin *CPluginManager::LoadPlugin(const char *path, bool debug, PluginType type, char error[], size_t maxlength, bool *wasloaded)